Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
[DNS] Replace UMA macros with function calls
Clean up UMA macros and replace with UMA function calls.
Bug: 400637435
Change-Id: I617d3ec06ea1111381be777c95fe520044f6a604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387080
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Abe Boujane <boujane@google.com>
Cr-Commit-Position: refs/heads/main@{#1437991}
[DC] Pass request data in the DC API request as is
Before this CL: Chrome would accept data objects that are either a
string or a json object, and in both cases Chrome would pass them over
to the platform and the wallet as a string in the request JSON
After this CL: Chrome honors the format that the verifier used. If it's
a string, it is forwarded as a string, otherwise as an JSON. This is to
be aligned with the latest DC API spec.
Bug: 357100947
Change-Id: If8ca07c6500bd6126281d8e999313ddbd2d6eb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357471
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437990}
Roll Skia from d1b71ea5e580 to 6bc9982ca375 (1 revision)
https://skia.googlesource.com/skia.git/+log/d1b71ea5e580..6bc9982ca375
2025-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3cf0e75590af to 7831e2ad53fd (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC maxhudnell@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: maxhudnell@google.com
Change-Id: I0378555b2eae5dd30709997055b3ddf2a4e41f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396367
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437989}
Remove unnecessary virtual specifiers
Clang has added a new warning for virtual specifiers on methods of
`final` classes. This cleans them up in preparation for enabling that
warning.
This CL was uploaded by git cl split.
R=poromov@chromium.org
Bug: chromium:403236787
Change-Id: I4aab95b9237e6d12d9171ced39535ca8fee37dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387702
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Auto-Submit: Devon Loehr <dloehr@google.com>
Cr-Commit-Position: refs/heads/main@{#1437988}
Dump when exceeded expected max allocation for Zstandard
Dump without crashing when the allocations from zstandard exceed the
maximum expected amount, to help track OOM errors.
Bug: 40945760
Change-Id: I3176dc5419da1c4c1eeee8acf438ff45e51ab583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6389899
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437987}
Revert "Ignore Letter Spacing in Cursive Scripts"
This reverts commit ba96d51e285f306ca12620dc201c5e8e34cb0521.
Reason for revert: This CL causes build failures, see https://issuetracker.google.com/u/1/issues/406300388
Original change's description:
> Ignore Letter Spacing in Cursive Scripts
>
> Cursive scripts do not allow gaps between their letters for either justification or letter-spacing. The following Unicode scripts are included: Arabic, Hanifi Rohingya, Mandaic, Mongolian, N’Ko,
> Phags Pa, and Syriac.
>
> Added logic to ignore the letter-spacing setting for cursive
> scripts, even if specified by the web author, as per the
> specification, to ensure that letter spacing does not break words.
>
> References
> https://www.w3.org/TR/css-text-3/#cursive-tracking
>
> Bug: 40618336
> Change-Id: I923a6e876e4643b894acde4bf11a4004ee32f65c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6359122
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Dileep Maurya <dileepmaurya@microsoft.com>
> Commit-Queue: Sejal Anand <sejalanand@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1437955}
Bug: 40618336
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I9984294b44cf4c23f590af5a6fd63b1e4c247b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394180
Auto-Submit: Florian Jacky <fjacky@chromium.org>
Commit-Queue: Florian Jacky <fjacky@chromium.org>
Reviewed-by: Florian Jacky <fjacky@chromium.org>
Owners-Override: Florian Jacky <fjacky@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437986}
Prerender: Pass SpeculationRulesTags up to PrerenderHost
This is a preparation for supporting Speculation Rules tags for
prerendering. This CL passes SpeculationRulesTags from PrerenererImpl to
PrerenderHost, so that follow-up CLs can add the Sec-Speculation-Tags
HTTP header based on that.
PrerendererImpl passes other Speculation Rules specific parameters like
the target hint and the eagerness. For code simplification, this CL
bundle them into SpeculationRulesParams struct and also adds
SpeculationRulesTags into the struct.
This CL changes SpeculationRulesTags from movable-only to
copyable-and-movable, as its owners (PrerenderAttributes and
SpeculationRulesParams) can be copied.
Bug: 381687257
Change-Id: Id330fbc2ca71ecc314f33375e69ade84a8ff1ebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6383243
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Huanpo Lin <robertlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437985}
check_cronet_dependency: drop remoteexec related gn args
use_remoteexec will require 2-level depths for out dir
to get better cache hit, but gn used in check_cronet_dependency
would use different out dir.
https://chromium-review.googlesource.com/c/chromium/src/+/6394219
https://ci.chromium.org/ui/p/chromium/builders/ci/android-cronet-arm-rel/197360/overview
no need to use remoteexec related gn args in check_cronet_dependency.py
Bug: 406270633
Change-Id: I41519d60439caa8863549261b91af75d71867b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395935
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Cr-Commit-Position: refs/heads/main@{#1437984}
Roll clank/internal/apps from b331c872ff1c to 1a2077aabe6b (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/b331c872ff1c..1a2077aabe6b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,sideyilmaz@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: sideyilmaz@google.com
No-Try: true
Change-Id: I2819e448ded432306819e8587cfdb18c4be53ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396368
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437983}
[//cc] Have BitmapRasterBufferImpl create backing internally
Aligns with how ZeroCopyRasterBufferImpl works, which will ease folding
BitmapRasterBufferImpl into ZeroCopyRasterBufferImpl in a followup.
Bug: 403372453
Change-Id: Ib634012d262648800f2e7024d5c37bec8f503c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387053
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437982}
[Blink] Add ability to read WebGPU front buffer
* Store SharedImage sent to compositor
* In GpuCanvasContext::PaintRenderingResultToCanvas(kFrontBuffer),
create a Dawn texture associated with that SI and copy it into the
ResourceProvider given by the caller
Bug: 40902474
Change-Id: I8c18e5975ea276d59f76b121d3f4244e9ff67590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388222
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437981}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1742947124-dabff686c9b781ea1c10bc9515b33bf42c89c62b-ad263f808bd48f3fa53a56c913c1c7befc1b03a9.profdata to chrome-linux-main-1742968203-def0f6f3088aa13cb8926d5b72f0cb2f451c2714-32ded76ab479c797927e2a0fb4e1fc298dd95450.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I42774c7745c3741e2b2570cbd0b8e0cbddfd9299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396364
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437980}
Roll androidx from k-MsooGnfN74pnqQS... to A0eDZ6ce3bRpY4ZG-...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: I98f08d2c36c8f3d989a16f99293367b7d5527cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396330
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437979}
[Blink] Have AcquireCachedProvider() take in SharedImage types
Next step in changing WebGpuResourceProviderCache away from using
SkImageInfo.
Bug: 371227617
Change-Id: I5f79c02a25655cd5cd61ab219af82f0c5007eea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388138
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437978}
WebAuthn: Make immediate selector UI keyboard accessible
Recording: https://photos.app.goo.gl/jMCnt1C1C8B7K6o57
Bug: 393055190
Change-Id: I475fce3767f0d5a24ba1d45b8b3ae603878858ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387483
Commit-Queue: Adem Derinel <derinel@google.com>
Reviewed-by: Rafał Godlewski <rgod@google.com>
Cr-Commit-Position: refs/heads/main@{#1437977}
webrtc: fix transitive includes
Landing
https://webrtc-review.googlesource.com/c/src/+/381801
showed some transitives includes in blink_platform_unittests missing
BUG=webrtc:42226242
Change-Id: Ic89c1775c14b1f42fe4fccfc167d56c7f309adde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393922
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437976}
Revert "Update FindBadRawPtrPatterns.cpp for Clang API change"
This reverts commit b8833a89a048145a111a6eed6866b6813daae464.
Reason for revert: Upstream change was reverted, see
https://crbug.com/406271686
Original change's description:
> Update FindBadRawPtrPatterns.cpp for Clang API change
>
> MatchFinderOptions moved in https://github.com/llvm/llvm-project/pull/128150
>
> Bug: 403519834
> Change-Id: Ifa90934e90e9626fb3f946a0253efc190d79f19e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6355808
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Auto-Submit: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1432805}
Bug: 403519834,406271686
Change-Id: If72b2520db4ac60e65290c81dc69b77b9b65acdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395695
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437975}
[Blink] Make CanvasResourceProvider::RecycleResource() private
Tuck it inside a new
CanvasResourceProvider::OnResourceReturnedFromCompositor() method. This
will enable moving the invocation of RecycleResource() down into
CanvasResourceProviderSharedImage in a followup (the other CRP
subclasses that have CanvasResources are single-buffered and hence will
always bail out of RecycleResource()).
Bug: 352263194
Change-Id: I9bffbef9748b3238e062b2a829df4ffe1f9357e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387822
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437974}
[AutofillAi] Bring back description list role on save dialog
This was deleted by accident
Bug: 399658462
Change-Id: Ib73fa4c345d1c02b075649540fe9fc04c4c5641d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6392936
Reviewed-by: Theo Cristea <theocristea@google.com>
Commit-Queue: Bruno Braga <brunobraga@google.com>
Cr-Commit-Position: refs/heads/main@{#1437973}
Remove stale WebGL 1 expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl1_conformance
Affected bugs for CL description:
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 328102507
Change-Id: I72c651f840dbd8e53c09456e1391a2ce18108d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395519
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437972}
infra: Switch WebRTC Chromium builders from Reclient to Siso's builtin client
Most Chrome builders have switched to use_reclient=false.
This CL applies the change to WebRTC Chromium.
Bug: 379584977
Change-Id: I61fca70fe95b96c118d87895584e9c0fceea80f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396478
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437971}
Roll Release Scripts from 3b193157a192 to 5ef98e67b91f (1 revision)
https://chrome-internal.googlesource.com/chrome/tools/release/scripts.git/+log/3b193157a192..5ef98e67b91f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/release-scripts-chromium
Please CC chrome-release-infra@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
Change-Id: Ib6eef8cf6cf97398180ec5c2dc5ef6cb9333646a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395594
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437970}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1742965539-eda9fb37bedb25f1a7c375e3123ff11b4ca1c52a-53a3cd0735cab9ebd102ff11b890bc169d9ce986.profdata to chrome-android64-main-1742968915-d5a024def062fbfefa9fb49cf5b6bea51abce829-eed20efdf585aea4beca920d35d338727ef3c1d4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I4ae36616754d1f004db46299710ff259a13bc780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396576
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437969}
Remove stale WebGL 2 expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webgl2_conformance
Affected bugs for CL description:
R=rubber-stamper@appspot.gserviceaccount.com
Bug: angleproject:389733590
Change-Id: I7f35ccb2ff73d3e3c35983bf611aa37361e2df9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395524
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437968}
Prepare unsafe buffers file for upcoming libc suppression.
The CL at https://crrev.com/c/6393815 shows we are getting closer to
having clean builds with libc warnings enforced.
Update some required suppression before turning on the warning to allow
for easier reversion down the road, when required.
-- Re-format file and alphabetize, shorten comments
Bug: 390223051
Change-Id: I308a2332e4c43d243d5ff3f9ac4931f9aab3b849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394415
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437967}
Remove stale webcodecs expectations
Autogenerated CL from running:
//content/test/gpu/unexpected_pass_finder.py --project chrome-unexpected-pass-data --include-internal-builders --remove-stale-expectations --narrow-semi-stale-expectation-scope --num-samples 300 --suite webcodecs
Affected bugs for CL description:
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 371802469
Change-Id: Ib95941c3c82841c25376878e9a543a6e3dae75e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395857
Auto-Submit: chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com <chrome-automated-expectation@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437966}
infra: Switch codesearch trybots from Reclient to Siso's builtin client
These builders don't seem running actively. But, I want to make sure setting `use_reclient=false` on these builders, too.
https://ci.chromium.org/ui/p/chromium/g/tryserver.chromium.codesearch/builders
Bug: 379584977
Change-Id: I82a4a7bfc81f0419fcaff72b52b2f7fd9308aaa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396479
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1437965}
Roll PDFium from cc534b45e0aa to 89da8e11e766 (2 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/cc534b45e0aa..89da8e11e766
2025-03-25 thestig@chromium.org Roll third_party/skia/ 6ca926db5..2bc5ed566 (1 commit)
2025-03-25 dloehr@google.com Remove unnecessary virtual specifiers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC dhoss@chromium.org,thestig@chromium.org,thestig@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:403236787
Tbr: thestig@google.com
Change-Id: I31562616adc310ed6645285f5c0dab93b40e5f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395592
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437964}
Roll Skia from d11d81b56f8c to d1b71ea5e580 (1 revision)
https://skia.googlesource.com/skia.git/+log/d11d81b56f8c..d1b71ea5e580
2025-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a66eb387fb8b to 006a8300ca77 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC maxhudnell@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: maxhudnell@google.com
Change-Id: I1cbf9b80fd568cbeb0c05c373b3865585f0de19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396269
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437963}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1742947124-4f91299c4f17d8f636c1d4938847434c289a618b-ad263f808bd48f3fa53a56c913c1c7befc1b03a9.profdata to chrome-win32-main-1742957784-b1b8847000df27b7c614c9a99bb14c272d9b7d1a-456b7708311e76034c8ae5dd73f0e859745f837b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7fd18797bf379fd048c7d73726d14f7d2a3b383a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396164
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437962}
Roll Catapult from ca135ac1f3c4 to 5b44c1060a53 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/ca135ac1f3c4..5b44c1060a53
2025-03-26 cammie@chromium.org Shared Storage: Temporarily disable tests for DevTools Protocol changes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,jbudorick@chromium.org,jiaxindong@google.com,johnchen@chromium.org,sullivan@chromium.org,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:401011862
Tbr: jiaxindong@google.com
Change-Id: Ifda2b5775c9eb3203414dc6d841bc2865c1af4cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396361
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437961}
Reland "siso: Re-enable remote proguard step along with remote trace_references step" along with remote trace_event_bytecode_rewriter step
This reverts commit 783d8fb43ba406fb79aba1ac51f2efbddb32584b.
Reason for revert: The root cause of the incremental build issue
with remote proguard step is that the outputs of trace_event_bytecode_rewriter step aren't specified in the build
graph. This wasn't an issue when running proguard step locally
since it accesses to the newly generated rewritten jar files.
However, this becomes problematic when running proguard remotely.
Siso doesn't recognize that the rewritten jar files have been
regenerated. Thus, Siso sends remote proguard step with the previous
hashes of the rewritten jars.
This CL avoids the issue by complementing the outputs of trace_event_bytecode_rewriter step at Siso handler + run it remotely.
(See the diff https://crrev.com/c/6365557/1..5)
Note that this isn't ideal because "cleandead" won't be able to
work well with the unknown outputs. However, specifying the outputs
in GN configs doesn't seem easy at this moment.
Original change's description:
> Revert "siso: Re-enable remote proguard step along with remote trace_references step"
>
> This reverts commit bd80b06db18cd132f3e4a5682b6ab07cea0c823c.
>
> Reason for revert: The issue still occurs.
> https://ci.chromium.org/ui/p/chromium/builders/ci/android-11-x86-rel/16925/overview
>
> Original change's description:
> > siso: Re-enable remote proguard step along with remote trace_references step
> >
> > This CL enables remote proguard step + enables remote trace references step. They used to run in the same script, and separating them to two
> > different steps may cause incremental build issue.
> >
> > Bug: 398058215
> > Change-Id: Iaaec645e790340083a561499856a8c8faeedacd8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6356469
> > Reviewed-by: Fumitoshi Ukai <ukai@google.com>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Junji Watanabe <jwata@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1433327}
>
> Bug: 398058215
> Change-Id: I13c07d00da2f810aa999b86127497cceb78e230b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6365154
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1433960}
Bug: 398058215
Change-Id: I94a813bac9bd69925c3ffd1f5904b85d890d2fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6365557
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1437960}
[DevTools] Rebaseline tests after https://crrev.com/c/6382153.
Fixed: 405312529
Change-Id: I84d04f7d2c0e78eca593a047276662409260117f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396535
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437959}
[android-10]: Disable failing tests on try builder
This CL disables some failing tests on try builder
and also splits the gl_tests filter as test failing
are different for android-10
Bug: 390670398
Change-Id: I2a59517ff9f7a3328287ff0af548a9133c841397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394299
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437958}
Split sliding_window_size and max_histogram_buckets for the individual LCPP subprojects
Currently, LCPP projects share the following fields.
- sliding_window_size
- max_histogram_buckets
Sharing these fields prevents us from specifying different values for
the individual subprojects of LCPP.
Bug: 40063266
Change-Id: I92d88f17a48092f9f9200cdb1a72150509367293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6389125
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437957}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1742947124-e2fb1c356ee4639a0b1683a83d39b352c9c28ba7-ad263f808bd48f3fa53a56c913c1c7befc1b03a9.profdata to chrome-win-arm64-main-1742968203-74d2143f672636cfa6adc2022e7ce458f009d450-32ded76ab479c797927e2a0fb4e1fc298dd95450.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3921bf78bbe283e334c591f10b764f32a3cdf9d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396363
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437956}
Ignore Letter Spacing in Cursive Scripts
Cursive scripts do not allow gaps between their letters for either justification or letter-spacing. The following Unicode scripts are included: Arabic, Hanifi Rohingya, Mandaic, Mongolian, N’Ko,
Phags Pa, and Syriac.
Added logic to ignore the letter-spacing setting for cursive
scripts, even if specified by the web author, as per the
specification, to ensure that letter spacing does not break words.
References
https://www.w3.org/TR/css-text-3/#cursive-tracking
Bug: 40618336
Change-Id: I923a6e876e4643b894acde4bf11a4004ee32f65c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6359122
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dileep Maurya <dileepmaurya@microsoft.com>
Commit-Queue: Sejal Anand <sejalanand@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1437955}
Roll Release Scripts from 039f09d30953 to 3b193157a192 (1 revision)
https://chrome-internal.googlesource.com/chrome/tools/release/scripts.git/+log/039f09d30953..3b193157a192
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/release-scripts-chromium
Please CC chrome-release-infra@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
Change-Id: If2a26834b31c730d65e2a839271dc92b10cf06fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396357
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437954}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1742961574-4a50e48e38e731a20ad793504b8388b37d7923c3-de17170f9ef0643dabbb8ceadb3d92953793450d.profdata to chrome-mac-arm-main-1742968203-bbc615b2988f575c038618d55ffc252a1873cb1d-32ded76ab479c797927e2a0fb4e1fc298dd95450.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7ebfe206800abb82216babcd81835053820a98c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395526
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437953}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1742961873-3ae8da23821576a22a1a45d687391053c7c53918-5cc0bcf722f5062efaea1be901d261f4da43f30f.profdata to chrome-android64-main-1742965539-eda9fb37bedb25f1a7c375e3123ff11b4ca1c52a-53a3cd0735cab9ebd102ff11b890bc169d9ce986.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ie9afbca1f43e939bf03965bc078db9f6b8a8d10b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396359
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437952}
Reland "demomode: Delete user created files between shopper sessions"
This is a reland of commit 7166891c627dc309ab9fee80a4e56af9416d022c
Fixed MSAN tests.
Original change's description:
> demomode: Delete user created files between shopper sessions
>
> Delete all files under 'MyFiles' and reset demo media data when device
> is idle, which is the end of one shopper session.
>
> Bug: 396731490
> Change-Id: Ic9a2f69f33261661dc771a980f036f14580cf1b0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292333
> Reviewed-by: Li Lin <llin@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1433918}
Bug: 396731490
Change-Id: I4ffbb58603780b538a2f0b2e9db1083be623775a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367236
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Reviewed-by: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437951}
Update user remote command feature name
Change the feature name from kUserRemoteCommands to
UserRemoteCommands for better consistence.
Change-Id: If186dadc9c2bc44dd691683c9ac455439200e74c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395215
Reviewed-by: Salma Elmahallawy <esalma@google.com>
Commit-Queue: Salma Elmahallawy <esalma@google.com>
Cr-Commit-Position: refs/heads/main@{#1437950}
[MVT Customization] Refactor MostVisitedTilesLayout margin computation.
This CL is a partial re-submit of crrev.com/c/6324689, which was
reverted in crrev.com/c/6342572, complementing crrev.com/c/6356790 :
* Update tablet edge margins computation, so that the UI decision to
avoid changing from scrollable container -> centered container becomes
more explicit.
Details: Update MostVisitedTilesLayout:
* Correct "padding" to "margin" in naming.
* Dimension fields: Use DP where applicable, since it's better to add DP
sizes before converting to PX, instead of converting first.
* Add "Dp" or "Px" suffixes wherever applicable.
* Extract computeContentWidthPx() (use DP for calculation first)
* Extract computeEdgePaddingPx(), simplify logic and add comments.
* Replace |mInitialTileNum| with |mInitialContentWidthPx|.
* Simplify updateEdgeMarginTablet() to use the above.
Bug: 400481269, 388782412
Change-Id: I55efe637a8e0ff256f4162f5e480288075c27090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6390176
Auto-Submit: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437949}
file_system_provider: remove FileBrowser.Diversion metrics
Diversion launched some time ago. The metrics are no longer needed.
Bug: b/398847594
Bug: b/398847628
Test: CQ
Change-Id: I47be9674bdaa9cbbedc1efc428c412e556342e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396176
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: François Degros <fdegros@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437948}
Update the value of LabelPieces for CreditCard
This CL updates the method of LabelPieces() in CreditCard class
to support new FOP display on settings page.
Bug: b:401602606
Change-Id: Iea554647613f6757d1113f9ddfb8304c62b2097c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378663
Reviewed-by: Olivia Saul <jsaul@google.com>
Commit-Queue: Qihui Zhao <qihuizhao@google.com>
Cr-Commit-Position: refs/heads/main@{#1437947}
Extend FileBrowser.ExtractTask.Status
Bug: 397217328
Change-Id: Iab5b4475dca784c865eab83bff3f8de5b376cfe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6389360
Auto-Submit: François Degros <fdegros@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437946}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1742955982-ff5b33f175b5e651893ecd76562acc1bf9a7f018-51f7b7070aa3de80b50019793d4d42fc54ded24b.profdata to chrome-android64-main-1742961873-3ae8da23821576a22a1a45d687391053c7c53918-5cc0bcf722f5062efaea1be901d261f4da43f30f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I6660b46c725fb0719a291fabe31de7cd403ab47d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396263
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437945}
Automated Commit: LKGM 16232.0.0-1067742 for chromeos.
CrOS Changes (16231.0.0-1067725 -> 16232.0.0-1067742):
- External: http://go/cros-changes/75563..75580?ext=true
- Internal: http://go/cros-changes/109131..109148
Uploaded by https://ci.chromium.org/b/8719406637582314737
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-octopus-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-jacuzzi-rel
CrOS-LKGM: 16232.0.0-1067742
Cr-Original-Build-Id: 8719406637582314737
CrOS-External-Manifest-Position: 75580
CrOS-Internal-Manifest-Position: 109148
Change-Id: I010942d202feb33322ba6c9016e0e2639bdbe1b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395978
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437944}
HttpStreamPool: Add debug instrumentation
There seems a case where we don't set `most_recent_tcp_error_` after
all TCP attempts are failed. Reported minidumps don't contain enough
information to identify the cause. This CL adds some
base::debug::Alias to identify the cause.
Bug: 403373872
Change-Id: I7161d2e8703c58d6640b67cf638157d4481447e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395996
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437943}
Roll src-internal from f6341d1ed688 to e64fd5f60a57 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6341d1ed688..e64fd5f60a57
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,hayato@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: hayato@google.com
Change-Id: I005308d54f6ceafdcb2fa27d722dd3f5d4f59ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396159
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1437942}