Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
[FedCM] Add more multi IDP WPTs
Add some WPTs for some common features like context and mediation. Also,
remove existing obsolete WPTs.
Fixed: 335897601
Change-Id: Ibed280eb0901564699d0d1f4041c3b2f5b311530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490962
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292689}
Add connectionReused to ResourceReceiveResponse trace event
Bug: 324059246
Change-Id: I7554f1f136c3ef9655080c29cb461fd2eff052e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491003
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292688}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1714046043-89578b342abbedbf643b3a99c7fdf2431d62d0f4-97a817420b6a9546cc582986706d1c600272843e.profdata to chrome-linux-main-1714067963-95b1ce86a5104d32908db337294cd361dc8e08e2-814cda3e8e3cf26961487224e48b794c4ecbbfe3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie288acdfd4c3bbf7c58a220850ccae080dda864e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490274
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292687}
Remove leftover target t/b/r/modules:unit_tests_v2
Bug: 40221845
Change-Id: Id79d11901840e9e92dcd21dab194982e8ea63e73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485826
Reviewed-by: Pilar Molina Lopez <pmolinalopez@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292686}
Roll V8 from 83830af06273 to e779698bc70e (4 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/83830af06273..e779698bc70e
2024-04-25 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.107
2024-04-25 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update V8 DEPS (trusted)
2024-04-25 ahaas@chromium.org [handles] Change condition of static_assert
2024-04-25 ahaas@chromium.org [ia32] Add missing 'typename' in instruction selector
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I5ff773eaf82fde4ad3a723348c8ae660e08b5440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490178
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292685}
Cancel PDF download if tab is closed.
Bug: 337051466
Change-Id: I703063a723740210623f606086858f5097fa846a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491189
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shu Yang <shuyng@google.com>
Cr-Commit-Position: refs/heads/main@{#1292684}
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I70c4664df7ce08868073fc49d28692fe742fd5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5487422
Commit-Queue: Peter Boström <pbos@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292683}
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I310b5ef69b0c08885998fdff32bc3899e791e1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484384
Auto-Submit: Alison Gale <agale@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292682}
WebUI: Remove paper-tooltip from settings and Desktop platforms
Remove use of paper-tooltip in Settings. Since settings was the last
non-Ash user of this element, also remove the file on Desktop platforms.
Bug: 40943652
Change-Id: I0b4d20f8cc9b408141eeb3ba2a79720718fb190e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484376
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292681}
[WebAPKRestore] Try downloading icon
Download the icon for displaying in the restore UI
Bug: 41496289
Change-Id: I9c8dc1172628a2261142bc52e744ef906d5ab7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477948
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292680}
Roll optimization-guide from 228e86b5646d to 30f14f6261bb
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/228e86b5646d..30f14f6261bb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ie12507a66ada180a7d3544aab0389b196c1be9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490273
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292679}
Fix a crash caused by missing manifest because the path was incorrect.
The wrong path was '.../embedded_a11y_helper_manifest.json', but it was
supposed to be '.../accessibility/embedded_a11y_helper_manifest.json'.
When reading the 'extension_path' field from the ExtensionInfo object
fetched from the map, it was empty instead of the value we initially
assigned to it. This CL assigns a string to 'extension_path' using its
value instead of its reference.
Bug: 331491809
Change-Id: I07ec42c733f9dac4d0a07cf363aba9994a9cb40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486816
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Xiang Xiao <xiangxiao@google.com>
Cr-Commit-Position: refs/heads/main@{#1292678}
Cleanup for server card dedupe flag and its codebase usage.
This flag is related to suggestion of server cards for autofill when
both local and server copies of the same card exist on a Chrome
client.
There is also a cleanup on FormDataImporter logic for CVC storage. We
would use this flag to determine if we are saving the CVC to the local
card or to the server card. Since the launch, we are only offering to
save CVCs for duplicate cards to the server card copies.
Fixed: 330367109, 40267452
Change-Id: I5a1db00bc81896cf9260d41730de6f5a3f80bfdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466810
Reviewed-by: Olivia Saul <jsaul@google.com>
Commit-Queue: Vipul Koul <koulvipul@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1292677}
Migrate sysroot to GCS first class deps
Object names taken from https://source.chromium.org/chromium/chromium/src/+/main:build/linux/sysroot_scripts/sysroots.json
Follow up CLs are needed to delete sysroots.json and update any docs
or scripts that refer to it.
Bug: b/336843415
Change-Id: Ia5d8a4a2c7619ad8c8439b110c7fad378aad8f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462469
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292676}
Cleanup: Remove puffin patches feature.
Assume the feature is enabled everywhere.
This is in response to a request on chromium-dev to clean up unused
features; I didn't file a bug for it (a bug seems like busywork).
Change-Id: I13ab7c293e3011308a5f51c1ac3a3835f5f4bb83
Fixed: b/337071324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490491
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292675}
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I6625a655ca218299853c369472f8c6950eccb35e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5487173
Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Auto-Submit: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292674}
webauthn: handle having local passkeys when Sync starts.
Empirically it's possible to hit the CHECK at the top of
`MergeFullSyncData` when creating local GPM passkeys and playing around
with Sync settings sufficiently.
This change doesn't add any actual merging of entities: remote updates
replace local ones. We could consider doing that in a future change,
although there aren't many cases where it makes sense.
Change-Id: Ie7c1e912602fbcdfcce9de37c1767ee4d64d8dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480147
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292673}
[STGV2] Implement "close tabs" commands on the tab context menu
Change-Id: I562018707fc0195873d156200b3de03474e1ed03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454940
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292672}
Roll GoogleTest from 5a37b517ad4a to d83fee138a9a (1 revision)
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/5a37b517ad4a..d83fee138a9a
2024-04-25 absl-team@google.com Adds "IWYU pragma: export" to gtest-param-util.h
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/googletest-chromium-autoroll
Please CC asully@google.com,jonathanjlee@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome
Tbr: asully@google.com,jonathanjlee@google.com
Change-Id: I3484b2f9301b8015f1fa433cbc8b98bf209f0926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490009
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292671}
Roll Media App from x51W3cWkkkJH91KyN... to k_T1fDsgK51V5-Ijx...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202404250800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/k_T1fDsgK51V5-Ijxcb4Nb2o4k0Akw0Sf6iCgpqZcM4C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,jomag@google.com,media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ic22d6479705ce7ec15daafcb99c9f0709d17a193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488791
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292670}
[omnibox] `AdjustedInputAndStarterPackEngine` to return struct, not pair
And avoid `std::tie` at the callsites.
Change-Id: Ic7376586870e027604b8c50f59f9d714e768ffa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5477015
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292669}
Add accessor for the product specifications sync entity from webui
This patch adds plumbing for the add/delete/get all methods of the
ProductSpecificationsService to webui.
Bug: b:330345730
Change-Id: I38e5931b2962c45ff971ef8e2c0c4a6c54127222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455952
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292668}
[printing] Remove print settings page orientation override
This CL is a follow up to https://crrev.com/c/5466494 which changed
the way page specific page orientation is passed to lower level
printing code. It removes the old way that involved overriding
the page orientation stored in global print settings. This could
have had some other side effects so it's good to have it removed
in a separate CL.
Bug: 332914943
Change-Id: I47c395dba8979e5661a734bd1e991f07bcffce8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491319
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292667}
Convert deferred tasks to lambdas where appropriate.
This also introduces the ability to add multiple tasks to
DeferredStartupHandler to allow multi-tasks to be created and
added to a list and then added in bulk (to reduce boilier plate).
This also splits out per-app tasks to a new method, which will
allow per-profile tasks to be be split out in a following change.
Bug: 337037827
Change-Id: I7c3e13b40e0c3527343f0a9a35f97cd8084847d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490999
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292666}
Add updateIfOlderThanMs histograms
Bug: 331226122
Change-Id: I34d14ab4fd372b46ced21fc15b257ec2cefa03ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490859
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292665}
[Tab Switcher] Disable verifyTabGroupStateAfterReparenting
Launching a second activity is causing Hub to try and open due to
inconsistent flag states.
This test should be migrated to support Hub.
Bug: 337061378
Change-Id: I56c534b959764a2cd101b41652db6cf9acf97e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491520
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292664}
Metrics: Update GoogleUpdate histogram expiry.
Fixed: b/336307712
Change-Id: I48cd66735b53d6ec6f4c0a4659abedffa2a33890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476296
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292663}
Android: Disable memory dumps on emulator with 16k page size
This is a work-around to make chrome & webview not crash in this
environment. It's not clear whether the crash is due to a chrome bug, or
an emulator bug (does not happen on real devices), so applying this
(hopefully temporary) work-around.
Memory dumps can still be enabled (to test the crash) via:
bin/chrome_public_apk run --args=--test-memory-log-delay-in-minutes=-1
Also changes --test-memory-log-delay-in-minutes=0 to use a delay of
1 second rather than 0 seconds (or else chrome just freezes up).
Bug: 330751658
Change-Id: I77e54abba8f3922c9f4824f4fbb0ea75607dc010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486189
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292662}
Android: Make system image .apk files use only base split when fuse_apk=false
Chanes system_image_apks.py in two ways:
1. If the output is an ".apk", use only the base.apk split (this is what
we want for webview)
2. If the output is an ".apks", then stop renaming files to not look
like an ".apks", since doing so messes up our signing infra.
Bug: 337005700
Change-Id: If6498cf4bd59e984ec77edfd7cd15b8a65e40835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490701
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292661}
Avoid dangling pointer in DialogModelHostField.
Bug: 40277363
Change-Id: Iaa22343ee5979411e52395a3436a289369df1cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479172
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292660}
Complete conversion for a few media histograms to variant syntax.
The base="true" part should have been removed when these histograms
were converted to variants in 38537e9f8dfe72652ccefe083c91317760d95064.
With the base annotation still there, the dashboard marks these
histograms as obsolete and refuses to display them.
R=evliu
Bug: 314837904
Change-Id: I6394de9a75d2668282ddfe626092b757ffca2936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490503
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Evan Liu <evliu@google.com>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292659}
Create expanded/collapsed shared pref for tab groups.
This collapsed pref defaults to expanded (not set). When a merge
occurs the resulting is purposefully expanded as it was interacted
with, and this is undoable.
Bug: 335487425
Change-Id: I38dc01f251234fcf61ed0aeee4f084de6e200914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463886
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292658}
Extend virtual/disable-intersection-optimization to May 30, 2024
Bug: 337069190
Change-Id: I0a6e18123311085215ee7f7fb82e24e830ff22fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490745
Reviewed-by: Stefan Zager <szager@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292657}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1714046043-946cebd9be212128b0685861b9da989eefe08adb-97a817420b6a9546cc582986706d1c600272843e.profdata to chrome-win-arm64-main-1714067963-3424b0ba4067a4c0803ae93ace034dbf6e4baa9c-814cda3e8e3cf26961487224e48b794c4ecbbfe3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If5366632a2f25af2c85f4989920e46d48ae5c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490943
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292656}
update comment for CertificateTransparencyAskBeforeEnabling flag to mention android
Change-Id: Ibc76a80b8557ecf608a928e9988019605fc2afe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490511
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292655}
[media] Remove legacy mailbox codepath from VideoUtil
Last few use case of legacy mailboxes have been removed. Accordingly,
ReadbackTexturePlaneToMemorySyncSkImage is never called and can be
removed.
Bug: 40057997
Change-Id: I36152e57c60d7ea04039cc6ab4c5fd3bf2c1136a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473365
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292654}
utr: add the reclient instance to utr test
It looks like the led builds were relying on gclient vars set by the
chromium orchestrator recipe. Add these properties so the reclient cfgs
will be fetched
Bug: 41492688
Change-Id: I0a7ca4a373965cb46bcfd44a421bfe0482caab9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490741
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1292653}
Store Encryptor key in encrypted memory
It's possible for the os_crypt encryption key to end up in
memory dumps e.g. taken intentionally, crashpad dumps, or
even WER dumps. As a defense in depth we should try and
prevent this from happening accidentally. This does not prevent
malicious processes from accessing this key as they could
still shim the APIs or simply inject code into chrome's
processes.
This CL encrypts the key in memory when not in use using the
Windows API CryptProtectMemory. It also cleans up some temporary
uses of the key by securely zeroing the memory after use. The new
code is behind a feature flag so any performance impact can
be measured before it is enabled by default.
Note: this does not change the storage of the DPAPI key, which
is still present in memory in the os_crypt sync code, as cleanups
have only been made to the newer app-bound key and async code.
Before this CL, this key was in two places in memory, now it is
no longer present in any chrome process (tested by dumping memory
and searching for it).
This CL augments an existing test to verify no behavior
change for encrypted cookies when the feature is both enabled
and disabled.
Also, because the APIs in use will not function inside the sandbox,
this CL also adds a new test to verify that the Encryptor
functions correctly inside a strong (kService) sandbox. In this
environment, the key cannot be encrypted in memory, were
it ever sent to such a process, so the API calls must fail
gracefully in that case.
In practice, the Encryptor is currently never sent to
a process with a sandbox this strong, as it is only sent to
the network service, where the APIs function correctly from
within the App Container sandbox.
To verify this, a test is added in content to verify that
when an Encryptor is sent across to the sandboxed network
service, the Key is not visible in a full memory dump.
BUG=335630159
Change-Id: I89e70022b0ada63155425e53aef0d5e4723bbc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458896
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292652}
Merge changes from tools/bisect-builds.py to tools/bisect/
For the past 8 years the two scripts have grown apart. Some
improvements were only done for 1 script.
This change basically does the following things:
1 Merge improvements from //tools/bisect-builds.py to
//tools/bisect/bisect_builds.py
2 Delete dead code like flash support.
3 A lot of formatting.
./bisect_builds.py -b 1291563 -g 1291500 -a linux64
./bisect_builds.py -b 1291563 -g 1291500 -a linux64 --verify-range
./bisect_builds.py -b 1291563 -g 1291500 -a linux64 --use-local-cache
./bisect_builds.py -b 126.0.6436.0 -g 126.0.6435.0 -a linux64
./bisect_builds.py -b 126.0.6436.0 -g 126.0.6430.0 -a linux64 -r
./bisect_builds.py -b 126.0.6436.0 -g 126.0.6430.0 -a linux64 -o
./bisect_builds.py -b 1291563 -g 1291562 -a linux64 -o
./bisect_builds.py -b 1291563 -g 1291561 -a linux64 -o
Not tested: Android stuff. I'll make sure they are well tested
before letting people know this script.
Test: Tested:
Bug: 332933533
Change-Id: I1b133537bcf94e65a246b3ce54776eb1014f0a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480391
Reviewed-by: Kuan Huang <kuanhuang@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292651}
[layout] Move checkbox/radio control baseline logic.
This is to minimize the diff for subsequent patches.
Bug: 40937312
Change-Id: I6b1adbcae7fb8c1c17a73c1eb12389077660c45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478111
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292650}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1713967183-384c99c79dfb0c384b437b56aa061c7f6e10dda9-0fccfea2aca0f04d39ae22bb93e47dcba9513d65.profdata to chrome-android64-main-1714060802-1be357bdd1f459522243ca28b01ac53d29e8a49b-7b4b81f6cbc63a525ee55bae27a3a68c2afb8bea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib862c3e98625820d18be9457ee3e0e1a60ceaf7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490266
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292649}
[iOS] Disable TabGridTestCase/testTapOnSearchScrimExitsSearchMode
Bug: 337067968
Change-Id: I0b4aa96606f345adc58884143a4887fb5932413a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490147
Commit-Queue: Noémie St-Onge <noemies@google.com>
Owners-Override: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Noémie St-Onge <noemies@google.com>
Cr-Commit-Position: refs/heads/main@{#1292648}
Add two new prototype OpenXr extensions
Adds two new OpenXr extensions for prototyping purposes of lighting and
depth estimation.
Bug: 40904930
Change-Id: Ic507efb0cbafc10b3aa713d2aa32c394dcbd015a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490506
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292647}
Roll devtools-internal from 777ad1a50aa8 to dae8590079f0 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/777ad1a50aa8..dae8590079f0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: Ibfe5af5940f5206f11338e7b5e0d185eb5d3570b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490264
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292646}
[ios] Fix gn check failure
The header file is conditionally depended on. We need to add
a // nogncheck so it doesn't trip up GN.
Bot failure https://ci.chromium.org/ui/p/chromium/builders/ci/ios-blink-dbg-fyi/25456/overview
Bug: 332360110
Change-Id: Id2a6863da447920f13c200586e4445b10358693c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488338
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292645}
Update a few TODOs in `visual_annotation_proto_converter.cc`.
Line: 93: The TODO is above this scope and requires a major update in
ax::mojom::Role
Line 215: Will be followed up in the context of another bug.
Line 448: The TODO is stale, we are now using the root id as well and
it is more concise to use AXTreeUpdate.
Line 458: Will be followed up in the context of another bug.
AX-Relnotes: n/a
Bug: 40064422
Change-Id: I9e2cde26d6fb98f6b2c7f726e77e17a1c53e722a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5488196
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Kyungjun Lee <kyungjunlee@google.com>
Commit-Queue: Kyungjun Lee <kyungjunlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1292644}
Reland "[User Education] Ensure correct histograms are emitted when IPH closes."
This reverts commit 2507621298c5d94d2f5e0405a5c7d39d51b97efc.
Reason for revert: Failing test was fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/5490699
Original change's description:
> Revert "[User Education] Ensure correct histograms are emitted when IPH closes."
>
> This reverts commit 10128567e1a1a56024b86118123476375a5e95a6.
>
> Reason for revert: bots failing
> `BrowserUserEducationServiceBrowserTest.
> FeatureConfigurationConsistencyCheck`
>
> Builder: linux-chromeos-chrome
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
> First failing build:
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/b8749756855657201249
> Step "browser_tests (retry shards) on Ubuntu-22.04" failing on builder "chrome/ci/linux-lacros-chrome"
>
> Builder: linux-lacros-chrome
> https://ci.chromium.org/p/chrome/builders/ci/linux-lacros-chrome
> First failing build:
> https://ci.chromium.org/p/chrome/builders/ci/linux-lacros-chrome/b8749745584149924881
> Step "browser_tests_no_field_trial on Windows-10-19045" failing on builder "chromium/ci/Win10 Tests x64"
>
> Builder: Win10 Tests x64
> https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64
> First failing build:
> https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8749744159778880113
>
> Original change's description:
> > [User Education] Ensure correct histograms are emitted when IPH closes.
> >
> > This is to ensure that when an IPH emits a kAbortPromo histogram value
> > (which is the fallback if no other close reason is given) it does not
> > correspond to some other result failing to be recorded; i.e. it ensures
> > that if, say, a promo was snoozed or dismissed, the correct histogram
> > value is emitted.
> >
> > Change-Id: I3b8a022664bdbe85ef5af6bb574d718e8b6a364a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467634
> > Reviewed-by: Mickey Burks <mickeyburks@chromium.org>
> > Commit-Queue: Dana Fried <dfried@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1291988}
>
> Change-Id: I88fac32d99e778275be6cc229dcc2d0103dd5bf5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485990
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Mikihito Matsuura <mikt@google.com>
> Owners-Override: Mikihito Matsuura <mikt@google.com>
> Commit-Queue: Mikihito Matsuura <mikt@google.com>
> Cr-Commit-Position: refs/heads/main@{#1292283}
Change-Id: Ie8344e058d8229207c22fdf3b7bcd2b85c32c8c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490510
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292643}
FSA: Update styling and spacing for Restore Permission prompt
This change adds rounded corners and updates spacing for the scroll
panel in the File System Access Restore Permission prompt
Screenshots:
With ChromeRefresh2023 enabled:
https://imgur.com/a/u8gEZNL
With ChromeRefresh2023 disabled:
https://imgur.com/a/0zW3kP5
Bug: 40942603
Change-Id: Iaf1b84f8b4bb426489ac3c0d0a0470b43e32bfaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415862
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Reviewed-by: Christine Hollingsworth <christinesm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292642}
Roll ChromeOS Atom AFDO profile from 126-6422.5-1713781547-benchmark-126.0.6437.0-r1 to 126-6422.5-1713781547-benchmark-126.0.6438.0-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: Id393266cc4b2381b2bafeba099394b4fe345cc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490068
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292641}
[Tab Groups] Compute tab group count on request
There was a bug with the old implementation where we would report 0
in some circumstances. I was unable to track down the source of the
issue after an hour of trying. This is only used very rarely in
production code (mostly for metrics). For now change this to a brute-
force approach rather than relying on the brittle tracking of additions
and removals we were doing manually before.
Fixed: 336080793
Change-Id: Ifc91ffd54db7f2261781f54de2f1807aa7254f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490619
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292640}