Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1713981585-8bdcc01511c797767aa5364efb1505763d308bc6-c04208c2fc20057f99c9b1c44a42b36469a9f9b8.profdata to chrome-win64-main-1713992391-ca12bb9bb61f1c0d6142f76077793c6b66edce73-f53c86cd76243ef68f87022047f02510109bfeea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9f58b2105d2e588c953886b9e90aac55c6d550a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485707
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292215}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1713981585-309cab7c1040ec498ed011e23fa980a862fc7b12-c04208c2fc20057f99c9b1c44a42b36469a9f9b8.profdata to chrome-win32-main-1713992391-39e9ffac7dcd22518d571ca779d9d5f927db0e04-f53c86cd76243ef68f87022047f02510109bfeea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I412d4c8e5aa948aa07a7478bb3bd208bb6c0fa30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485516
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292214}
Roll WebRTC from e92b143eea2d to caa1201a0800 (4 revisions)
https://webrtc.googlesource.com/src.git/+log/e92b143eea2d..caa1201a0800
2024-04-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f24efc069c..8b3f58c31e (1291744:1292052)
2024-04-24 eshr@google.com Add perfetto build config
2024-04-24 danilchap@webrtc.org Delete deprecated CreateVideoEncoderSoftwareFallbackWrapper
2024-04-24 phancke@meta.com sdp: cleanup WebRTC-PreventSsrcGroupsWithUnexpectedSize killswitch
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:40066610
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I62583e5b1f9afdcece47ab8d4dcdca8f2fe5682a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486075
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292213}
Revert "Roll Perfetto from 234fd02711c6 to 196f4d514c28 (53 revisions)"
This reverts commit 1fd14d08d3208244737a2e88ba48a74aac9982e6.
Reason for revert: Broke UBSan
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/29667/test-results?sortby=&groupby=
Original change's description:
> Roll Perfetto from 234fd02711c6 to 196f4d514c28 (53 revisions)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/234fd02711c6..196f4d514c28
>
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Fix `uint` -> `uint32_t`" into main
> 2024-04-24 oksamyt@google.com Merge "Update chrome_scroll_inputs_per_frame.sql to use EventLatency" into main
> 2024-04-24 ddiproietto@google.com Merge "Use `am get-current-user` instead of `cmd user get-main-user`" into main
> 2024-04-24 stevegolton@google.com ui: Tidy up commands
> 2024-04-24 stevegolton@google.com Merge "ui: Fix double scrollbar sometimes seen in Ftrace/Android logs tabs" into main
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Improve dominator tree view performance" into main
> 2024-04-24 keanmariotti@google.com Merge "protozero: allow top-level extension blocks" into main
> 2024-04-24 vilasbhat@google.com Merge "perfetto: Fix issues with proto update tools on tip-of-tree" into main
> 2024-04-23 lalitm@google.com Merge "ui: overhaul track decider queries to make things faster" into main
> 2024-04-23 vaage@google.com Merge "Trace Redaction - Frame Timeline" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "protozero_plugin: print extensions" into main
> 2024-04-23 lalitm@google.com tp: implement an implicit segment-tree like data structure
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Revert "protozero_plugin: print extensions"" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "Fix segfault in trace processor" into main
> 2024-04-23 lalitm@google.com tp: fix multiple minor bugs with cengine
> 2024-04-23 lalitm@google.com ui: remove arg autocompletition in pivot table
> 2024-04-23 rsavitski@google.com Merge "ui: change "dead" task color to gray and render dead tasks from old kernels (<4.14)" into main
> 2024-04-23 etiennep@google.com Merge "[chrome] Register MetadataModule for kChromeTriggerFieldNumber" into main
> 2024-04-23 oksamyt@google.com Merge "COPYBARA_IMPORT=Project import generated by Copybara." into main
> 2024-04-23 bql@google.com Merge "Revert "ui: show heap graph dominator tree default to true"" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "proto_gen.bzl: emit --proto_path for dependencies" into main
> 2024-04-23 rasikan@google.com Merge "[chrome-stdlib] Fix OWNERS file for Chrome Stdlib" into main
> 2024-04-23 android-test-infra-autosubmit@system.gserviceaccount.com Merge "improve typescript docs" into main
> 2024-04-23 ddiproietto@google.com protozero_plugin: print extensions
> 2024-04-23 keanmariotti@google.com Merge "Build perfetto_trace_javastream_protos from list of files" into main
> 2024-04-22 vaage@google.com Merge "Trace Redaction - Drops fields, not packets" into main
> 2024-04-22 rsavitski@google.com ui: promote Steve to owner of chaos
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from src/traced/probes/ftrace/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/src/plugins/dev.perfetto.BookmarkletApi/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/release/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from ui/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from test/vts/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from test/cts/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from src/trace_processor/perfetto_sql/stdlib/common/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from protos/perfetto/ipc/OWNERS" into main
> 2024-04-22 rsavitski@google.com Merge "Remove hjd@google.com from infra/OWNERS" into main
> 2024-04-22 aattar@google.com Merge "[ETW] Fixes two main UI issues with ETW" into main
> 2024-04-22 stevegolton@google.com Merge "ui: Fix buggy counter duration calculation" into main
> 2024-04-22 rasikan@google.com [chrome-stdlib] Add Chromium owners to subdirectories of Chrome Stdlib
> 2024-04-19 stevegolton@google.com ui: Roll canary
> 2024-04-19 simonmacm@google.com Merge "Proto definitions for modem custom data source. Bug: 335603768" into main
> 2024-04-18 stevegolton@google.com Merge "ui: Fix broken table header CSS" into main
> 2024-04-18 bql@google.com Merge "ui: show heap graph dominator tree default to true" into main
> 2024-04-18 amanvr@google.com Merge "COPYBARA_IMPORT=Project import generated by Copybara." into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Fix indirect include" into main
> 2024-04-17 simonmacm@google.com Don't show '?' for unknown units.
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Filter suspend resume events" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Update filter ftrace events to use common fixture" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Update scrubs ftrace events to use common fixture" into main
> 2024-04-17 vaage@google.com Merge "Trace Redaction - Extract prune package list tests" into main
> 2024-04-17 stevegolton@google.com Merge "ui: Defer invoking `Track.onCreate()` until the track is in view" into main
> 2024-04-17 aattar@google.com Merge "[ETW] Adds EtwParser and EtwShedEventTracker to trace processor." into main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
> Bug: chromium:276433199
> Tbr: perfetto-bugs@google.com
> Change-Id: Iaf33f581fcc62aca6d21092c5c744c64a8d2f090
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484214
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1292043}
Bug: chromium:276433199, 335456429
Change-Id: Ie43d2d847cde701616d1b5547caa1697f199c192
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486716
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Mikihito Matsuura <mikt@google.com>
Cr-Commit-Position: refs/heads/main@{#1292212}
Revert "Roll Perfetto from 196f4d514c28 to 763aab383f2e (1 revision)"
This reverts commit 41f70025d26bdabe4a0c175336d6249cfd47a098.
Reason for revert: to revert https://crrev.com/c/5484214
Original change's description:
> Roll Perfetto from 196f4d514c28 to 763aab383f2e (1 revision)
>
> https://android.googlesource.com/platform/external/perfetto.git/+log/196f4d514c28..763aab383f2e
>
> 2024-04-24 android-test-infra-autosubmit@system.gserviceaccount.com Merge "tp: fix subtle issue with process <-> package matching for isolated apps" into main
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://issues.skia.org/issues/new?component=1389291&template=1850622
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
> Bug: None
> Tbr: perfetto-bugs@google.com
> Change-Id: I15c426de93d29f4793bae0cd9254b5a211abd120
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484465
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1292113}
Bug: None
Change-Id: I1460c7c30d12393103ba43da3fee7e6750725f21
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486796
Auto-Submit: Mikihito Matsuura <mikt@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292211}
Multi-Calendar: Add metrics
+ Added metrics to record the calendar list fetch duration, error
code, whether or not the request timed out, and the total amount of
selected calendars in the user's calendar list.
+ Added a metric for the total duration of a single month's calendar
event fetches.
+ Split TimeToSeeTodaysEventDots into single-calendar and multi-calendar
metrics.
+ Parameterized the post-login glanceables metrics recorder calendar
fetch test.
+ Added calendar list model metrics tests.
Bug: b:308699414
Change-Id: I04d21bc8ecab97879420585dcaa8bf1423b7fa8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454602
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org>
Reviewed-by: Courtney Wong <courtneywong@chromium.org>
Reviewed-by: Michele Fan <michelefan@chromium.org>
Commit-Queue: Amber Haynes <amberhaynes@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292210}
Update voice install status even if there are no natural voices
Followup on crrev.com/c/5474663. Not every downloaded voice pack has
natural voices, so remove that step. I also filter with availableLangs
rather than availableVoices because we were doing extra work since
there's multiple voices per language.
Fixed: 336280327
Change-Id: I6e73130f6d34425bc0631a9ddf7786788c0b6f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484772
Auto-Submit: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1292209}
Migrate ScreenlockMonitorDeviceSourceWin to SingletonHwnd
The current implementation of ScreenlockMonitorDeviceSourceWin
creates message-only windows to listen for events from Windows.
This impacts performance at startup where we have to pay the cost to
creating the window to listen. Instead use Singleton HWND in the
implementation of this component to allow sharing a single HWND. We
typically see 1-10ms costs for creating HWND in startup, so sharing the Singleton HWND will lead to modest but measurable startup improvements. Additionally, to support tests, the creation of singleton hwnd observerin BrowserAccessibilityStateImplWin is deferred to InitBackgroundTasks(). Originally, the SingletonHwnd in content_unittests was not initialized on the UI thread. This meant that OnWndProc was not called in ScreenlockMonitorDeviceSourceWinTest. The fix was to defer the creation of the singleton observer from BrowserAccessibilityStateImplWin() to InitBackgroundTasks() so the BrowserTaskEnvironment can be set first and the Singletonhwnd is created on a UI thread.
Bug: 40285703
Change-Id: Ia818e2dd8fb67ce21b14887f335d29c6895509cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469064
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Ishika Patel <ishikapatel@microsoft.com>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292208}
CrOS Settings: Create settings-dropdown-v2 element
Creates a new dropdown element with pref control capability. Non-pref
capability is deferred to a separate CL.
Bug: b:333454399
Test: browser_tests --gtest_filter="*OSSettings*SettingsDropdownV2"
Change-Id: Ie55ef075e763f7b086c95113038535d7486ab361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479487
Reviewed-by: Connie Xu <conniekxu@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1292207}
[Tab Group Sync] Replacing int by Token in native
This CL replaces the tab group ID data type in native to
base::Token from int.
Bug: 336663675
Change-Id: I7dc52fe4eb9f42a5b50829946051d6b8e164a897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481808
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292206}
[ASH] Remove extra divider line in CCT history info header
Bug: 332570741
Change-Id: Id506520a307f091970949bb3eb4752af01011e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484423
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292205}
Roll optimization-guide from 18abeb373b57 to 884eef64c843
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/18abeb373b57..884eef64c843
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Id9ae7e4ee98536bd36074c3b9251e839714c7bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486076
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292204}
Remove kForYouFre feature flag check from intro_ui.cc
The feature is now fully launched. This is part of the cleanup process.
Fixed: b:336751237
Change-Id: I7a4bcbb0880099f8d3ba4c9805ec20f48d8f2cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5481951
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Auto-Submit: Jack Yammine <jyammine@google.com>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292203}
[declutter] Plumb through boolean for inclusion in native TabModelList
Add a boolean to the TabModel constructor to indicate whether to include
the TabModel in the static TabModelList tracked in native. This static
list is used by sync types like sessions & send tab to self to observe
Tab/Models in Android. The archived tab model is the only current case
where this boolean is set to false.
Bug: 336581953,333582560
Change-Id: Iee0dd9a8e06185461dc9ba17b78e6ebbd3850724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478413
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1292202}
Wire overlay panel visibility and color to BottomAttachedUiObserver
https://screencast.googleplex.com/cast/NjI1ODA3OTU5NDE4NDcwNHw2ZTllOGQ5Yy1iYg
Bug: 329287585
Change-Id: Id7d85a762d827ffad24f651767db7e2d9b7623e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472457
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Charles Hager <clhager@google.com>
Cr-Commit-Position: refs/heads/main@{#1292201}
[Tab Group Sync] Implement getDeletedGroupIds
This CL completes the hookup of getDeletedGroupIds across JNI.
Deleted groups are groups that have been deleted from sync but open
locally. These groups will be closed in the tab model on the next
restart of the window if the window is not alive when the message was
received from sync. If the window was open, the group will be closed
and the entry will be deleted right away.
Also adds a few TODOs in tab_group_sync_service_impl.cc to invoke
mapping store when it's ready.
Bug: b/336792770
Change-Id: Id58f9e9babcc79cab9f6802e89c9c4ad69f3acea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484342
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292200}
[views-ax] Remove SetAccessibleName call from PrivacyScreenToastView
In preparation for the migration and removal of View::SetAccessibleName,
we're cleaning up a few files that were using it in a non-conventional
way.
PrivacyScreenToastView was using SetAccessibleName to cache the
accessible name in the `accessible_name_` member of the View class, so
it could later be retrieved by the GetAccessibleName method when
requested by the WidgetDelegate of the RootView.
While this was technically working, it was not the intended use of
SetAccessibleName, and it was causing test failures in CL:5445832 as
we are trying to migrate away from the `accessible_name_` member
on View.
This CL sets the accessible name directly on a new member of the
PrivacyScreenToastView class and removes the SetAccessibleName call.
In the near future, we will get rid of that new member and instead
notify the RootView directly when the accessible name changes, as part
of the ViewsAX project.
Bug: 325137417
Change-Id: Ia021a36c490802f2f43fd53be1f0a27d3b8e5250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484294
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292199}
Roll V8 from 06664036fd0b to 11f0340b1784 (3 revisions)
https://chromium.googlesource.com/v8/v8.git/+log/06664036fd0b..11f0340b1784
2024-04-24 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.96
2024-04-24 syg@chromium.org Unmark failing test fixed by ICU roll
2024-04-24 adamk@chromium.org Reland "[api] Advance deprecation of API not called by Chromium"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I131f5465a149616247acb787054bcca21273cfce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486073
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292198}
Revert "[Grid] Reuse a subgrid's MinMaxSizes cache whenever possible"
This reverts commit d8e813e56af22ac513bd3a4841948afaa650530f.
Reason for revert: Regression in live site - see https://issues.chromium.org/issues/336358908
Original change's description:
> [Grid] Reuse a subgrid's MinMaxSizes cache whenever possible
>
> 1. Removing the concept of only reusing the `MinMaxSizes` cache of a
> subgrid within the same step of the grid sizing algorithm in favor
> of reusing it in the second pass or within different runs of the
> `ComputeMinMaxSizes` and `Layout` methods if possible.
>
> 2. To determine whether we can reuse the cache or not we rely on the new
> `IsSubgridMinMaxSizesCacheDirty` flag in `LayoutObject`, but this
> change introduces more logic that determines if the cache must be
> invalidated depending on whether a subgrid's subgridded tracks
> changed between calls to compute its intrinsic sizes.
>
> 3. This change shouldn't have any behavioral impact.
>
> Significant perf deltas:
> - nested-subgrid
> avg 260.401 runs/s -> 286.556 runs/s (10% better)
>
> Bug: 1505606
> Change-Id: Id2cee4d5b412867f3002ae2f532fa7ebe1857d9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230717
> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
> Reviewed-by: Alison Maher <almaher@microsoft.com>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1266107}
Bug: 1505606,336358908
Change-Id: I209fe909dc9b70c0b05ec382ff130b0c905176aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484497
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292197}
views: use CalculatePreferredSize(SizeBounds) in //ash/system/media.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: Ic790aa3282312a0f4541a910d1811708bd7f5225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471027
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org>
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292196}
[Tab Group Sync] Replacing root ID with Token in UI layer
This CL is a follow up to the work that we have now ID mapping in
native (or soon enough we will have). So, in this CL, we
1. Replacing LocalTabGroupId to be based on Token instead of root ID.
2. Replacing construction of LocalTabGroupId in the Java layer to be
based on Token. We have already introduced the conversion methods
between Token and root ID, so we are using that heavily in this CL
wherever needed.
3. Also removes callsites for storing / reading mapping
since we will have it in native.
The next CL removes the LocalTabGroupId constructor that was based
on root ID, and migrates all places in native that used root ID
before. After these two CLs, we will have completely migrated to
Token. Only thing remaining is the persistence of ID mapping in
native, but that can be orthogonal to this change. So far we have
disabled the feature, so there would be no breakage.
Bug: None
Change-Id: I072f39b94217314c1b5a6bd3dd0451fe4aa1d6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480729
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292195}
Add support to get OSCrypt Sync compatible Encryptor instances
This CL adds a new optional parameter on the GetInstance call to
the OSCryptAsync factory class.
The option can specify that the caller wishes to be vended
an Encryptor that will be data-compatible with OSCrypt Sync,
even for data encrypted by the Encryptor, regardless of the
current configuration of OSCryptAsync.
This allows API consumers of OSCryptAsync to more finely control
their own individual roll-out strategy for adoption of
OSCrypt Async.
Many tests are also added, and documentation is updated with a
guide on how to migrate to OSCrypt Async using this option.
BUG=40241934
Change-Id: I0dfa518bc80a6b413e69f5c53205551fae89afed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479616
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292194}
[Tab Group Sync] Fix startup routine to handle multi-window
This CL fixes startup routine
1. The tab group IDs are now stored in native layer (still in
shared prefs, but loaded to memory before init is complete).
Hence we dont need to build the mapping from Java.
2. We still need tab ID mapping, start up routine does that.
3. Deleted groups from sync are deleted locally (along with
deleting mapping from sync) on startup. Relevant for
multi-winodw where the window may not be running to catch the
sync signals.
4. Force updates all local groups to sync for the reason
mentioned in 3.
Bug: None
Change-Id: I9377f69a3af43c8f959782e00ca1fcc8133f4e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480290
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292193}
FS Access: Create SyncAccessHandle if storage access is allowed
This CL ensures that Storage Access for the File System is allowed
before proceeding with the call to createSyncAccessHandle(...).
Bug: 328635898
Change-Id: I2cc37cec3bd0c77c0ea9c87216c493d056a82271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375420
Reviewed-by: Christine Hollingsworth <christinesm@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Daniel Soromou <fosoromo@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1292192}
[lensoverlay] Move scrim to spec
Bug: b:336380811
Change-Id: I122c0f8adff9b35977cb4e6e1074a0b07d5acc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484411
Reviewed-by: Bryan Nguyen <nguyenbryan@google.com>
Commit-Queue: Duncan Mercer <mercerd@google.com>
Cr-Commit-Position: refs/heads/main@{#1292191}
[media] Migrate KeySystemSupportImpl from singleton in the browser.
Migrate KeySystemSupportImpl from a singleton in the browser to an
object owned by RenderFrameHost.
Bug: b/321307544
Change-Id: I5aa092c3d2e14f266cd4643c924ec98247225c41
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479735
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Feras Aldahlawi <feras@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292190}
Add string for download message that shows in the voice menu
Bug: 326131870
Change-Id: Iff1a5c887c32f0f45296f24adde17df8c9c1607e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484604
Commit-Queue: Kristi Saney <kristislee@google.com>
Reviewed-by: Lauren Winston <lwinston@google.com>
Auto-Submit: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1292189}
metrics: Add metrics to distinguish invalid button registration
Distinguish invalid button registration between mouse and combo device.
Bug: b/335529142
Test: ash_unittests
Change-Id: Iaba182af79228bcf7e49b3aa2ff0281f06651dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464939
Commit-Queue: Danny Wang <wangdanny@google.com>
Reviewed-by: David Padlipsky <dpad@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292188}
utr: rename utr-tester to linux-utr-tester
There will be a windows version of this builder as well eventually so
specify this one as linux
Bug: 41492688
Change-Id: I2ed6a4d1a0bd28595d1ad462eaf16764fa25c5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484377
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292187}
Automatic Fullscreen: Reshow fullscreen bubble on first input
Overhaul ExclusiveAccessBubble and related code:
- Remove unused code, simplify and clarify, add unit tests
- Inline some logic in the Views-subclass
Reshow on first input after fullscreen without recent interaction
- Usable security mitigation for Automatic Fullscreen
Test: Automated; bubble works as before, except new automatic reshows
Change-Id: I5af5b0ad9bd08966d7615664cfda6e1223ecc84b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445712
Commit-Queue: Mike Wasserman <msw@chromium.org>
Reviewed-by: Brad Triebwasser <btriebw@chromium.org>
Auto-Submit: Mike Wasserman <msw@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292186}
[Read Aloud] Share the browser language code with the controller.
The regular language code is initially the browser language but updates
when a page language is determined.
However, since we should fallback to using the browser language in
case the page language is invalid in our speech engine, we should
still share the browser language as the "default" language with
WebUI.
Bug: 336596926
Change-Id: I669f447958d74cdf4a8ee6f5aa37bec3d09d6bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480295
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Lauren Winston <lwinston@google.com>
Reviewed-by: Kristi Saney <kristislee@google.com>
Cr-Commit-Position: refs/heads/main@{#1292185}
Roll androidx from zjTkDjEytq8UvMcux... to vH4-Dcmlv3sN2aI4c...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: Ia7e7a0e7b695c0529e2739a11e9a9532d07941dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485708
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292184}
[PWA] Clean up references to DesktopPWAsCacheDuringDefaultInstall
This CL cleans up references to the stale feature that has no
corresponding Finch configs and is enabled by default.
Bug: 336755887
Change-Id: I976ad84ce19fccdcbcedca50a41a477ccc0ba128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483572
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292183}
Add swiftshader to MSan ignore list
While it would certainly be preferable to MSan instrument Swiftshader,
there does not appear to be a viable path to doing so in the short or
medium term. Swiftshader is no longer actively maintained and is on the
blocking path to enabling -fsanitize-memory-param-retval (and by
extension, running Rust with MSan). This new MSan mode is stricter and
disallows passing uninit values as parameters or return values—which is
something that was previously only caught if the uninit parameter or
return value ended up being used in a conditional branch. ,
Swiftshader itself is being removed as a default fallback for WebGL (see
crbug.com/40277080) which should reduce the need to have this actively
covered by MSan.
Finally, also implement a more robust mechanism than a manual clobber
for ensuring correct MSan builds when the ignorelist changes.
Bug: 1369167
Change-Id: Icae46808ebe3c05966ab3f18ec2d90d66656a7e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440836
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292182}
Fix color contrast for app menu chip with custom themes
This only impacts custom web store themes with images in the toolbar.
With this change, the button background will be the same color as the
omnibar.
After:
https://screenshot.googleplex.com/ADFjBGLsSngC74o
https://screenshot.googleplex.com/7iDM6sS2QjobbtD
Before:
https://screenshot.googleplex.com/Aejbx5iXqfSDbij (text is visible but color of the button is clearly off)
https://screenshot.googleplex.com/kswHYA7gzbFEf4x (text is not visible and color doesn't match theme)
Bug: b/336707615
Change-Id: Id42d96bbaa7e1bc279d551a34d69d4ceb9db4af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484312
Reviewed-by: Shibalik Mohapatra <shibalik@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292181}
Add diagram comments to schedule_utils.
See bug for context. The intent is to port similar diagrams
from the old code structure to the new code structure so that
the reader can visualize the logic.
Bug: b:270472294
Change-Id: I324facf7cfdf547248328f28bc38ddfaf370d2d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473541
Commit-Queue: Eric Sum <esum@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292180}
views: use CalculatePreferredSize(SizeBounds) in //ash/display.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: I7d48bac2046e409265abdd1f870e4e2b34931152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471026
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292179}
[Fast Pair] Update and unify the expiry of histograms
Routine update to histograms, also unified the expiration dates for
quicker future updates.
Test: N/a, metadata change
Fixed: b/330165775, b/333390654
Change-Id: I65c246f870a8790bf38d57b533fa38b5a3eda011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484415
Auto-Submit: Crisrael Lucero <crisrael@google.com>
Commit-Queue: Jack Shira <jackshira@google.com>
Reviewed-by: Jack Shira <jackshira@google.com>
Cr-Commit-Position: refs/heads/main@{#1292178}
views: use CalculatePreferredSize(SizeBounds) in //ash/login/ui.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: Ib74e48f222b44667e731ab19e4273c2da49abddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465552
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Elie Maamari <emaamari@google.com>
Cr-Commit-Position: refs/heads/main@{#1292177}
views: use CalculatePreferredSize(SizeBounds) in //ash/app_list.
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
Bug: 40232718
Change-Id: I5b0317f088cebcd3763ae3d28a3765dc17a5570d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465408
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292176}
views: use CalculatePreferredSize(SizeBounds) in ['/ash/wm/desks/desk_button', '/ash/wm/desks'].
In order to ensure implementation consistency and avoid oversights, we
should unify CalculatePreferredSize() and GetHeightForWidth(). Replace
them with the CalculatePreferredSize(SizeBounds) overload.
This CL was uploaded by git cl split.
Bug: 40232718
Change-Id: I57999dbf12890d342696f7ce6fb97d878fb902df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465553
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Reviewed-by: Daniel Andersson <dandersson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292175}
Set COMPILER_RT_BUILD_CTX_PROFILE=OFF in tools/clang/scripts/build.py
New cmake flag was added upstream and we need to set it to off.
Bug: 336634956
Change-Id: I67c024013aa40bc4e68450e98ab0c9e3918f4d38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484424
Commit-Queue: Amy Huang <akhuang@google.com>
Reviewed-by: Arthur Eubanks <aeubanks@google.com>
Cr-Commit-Position: refs/heads/main@{#1292174}
[Tab Group Sync] Close tab groups on sign-out / turn off sync
For pre-UNO, the decision was to close all tab group on sign-out,
but they still stay in the user's synced account. As part of the
flow, the local DB and the in-memory model will be cleared. All
open tab groups will be closed along with the tabs.
Implemented behind a finch param that can be set per platform.
Bug: b:332633924
Change-Id: I2eaa3e085c406e8ae75b1df40b0207e219ecf383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462879
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292173}
Extensions and Profile Picker: Use cr-tooltip instead of paper-tooltip
Also adds cr-tooltip in the cr_elements shared styles, so that the
same CSS applied to paper-tooltips will be applied to cr-tooltips on
pages that use the shared style.
Bug: 40943652
Change-Id: I2d3d6134eef6f0393f4bc6552ad0b654f9f5712e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484343
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292172}
Optimize Element::HasClassName().
This optimizes Element::HasClassName() to avoid testing for and chasing
the same pointers twice.
While it might seem like the compiler would optimize away the
difference, it appears (from my local non-PGO build) that this change
removes a CMPQ instruction and a JE instruction from the generated code
on x86_64.
I found this while looking at a profile of the Speedometer3 subtest
TodoMVC-Preact-Complex-DOM. But this is probably too small of an effect
to show up in our measurements.
Change-Id: Iecf42fe6dca77878d91dd0240b62d20ffd7bcdd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479574
Auto-Submit: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292171}
wm: Remove pointer output parameters (1/N)
New style is to use return value or reference.
Test: manual
Bug: None
Change-Id: Iff66ebdbcc34454c77f0806b056c9781a70cb4e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484407
Reviewed-by: Michele Fan <michelefan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292170}
[tabs] Clean up discard interface for Tabs.
The only time that a WebContents is changed for a Tab is during tab
discard. Update APIs to reflect this new constraint.
Change-Id: I9e756d5b6341550b73bdf7c5e9f5201235ab88de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474504
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292169}
Set replication state origin whenever the RFH origin gets updated
This ensures the origins will always match between the RFH and the
FrameReplicationState. Currently it might not match when the
FrameTree/FrameTreeNode is newly created, where we set the
RFH origin but not the replication state origin.
Bug: 331646087
Change-Id: I9e56bfccf48597eee01b2ab81d8010c4a6ab68d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5446780
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292168}
gpu: Remove D3D default texture mapping
Now that multiplanar shared image is enabled by default on Windows, the
default mappable textures code path is unreachable since it only works
for single plane formats that were used with legacy multiplanar.
Bug: 40239769
Change-Id: I69bc1471e0682009b47a9a1c4e0b05c62e340583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484293
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292167}
Roll src-internal from 6015cc82ed05 to d6d93d035c8e (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6015cc82ed05..d6d93d035c8e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC charlesmeng@google.com,chrome-browser-infra-team on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:40279597
Tbr: charlesmeng@google.com
Change-Id: Iae2f449fdbb3fb13293a65ec424eab83f8a320b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5485513
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1292166}